Skip to content

Commit

Permalink
internal/core/debug: simplify logic of debug visualization
Browse files Browse the repository at this point in the history
Remove the special case for lets. This caused some
nodes to be dropped. These nodes are relevant for
upcoming algorithmic changes, so by dropping special
handling of lets we ensure that they are shown.

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: If49d214326d4f688e505ef95c9e74caadab62cb4
Reviewed-on: https://cue.gerrithub.io/c/cue-lang/cue/+/1199270
Reviewed-by: Daniel Martí <[email protected]>
Reviewed-by: Matthew Sackman <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
  • Loading branch information
mpvl committed Aug 12, 2024
1 parent 6cc01b0 commit 2e312df
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions internal/core/adt/debug.go
Original file line number Diff line number Diff line change
Expand Up @@ -551,15 +551,7 @@ func (m *mermaidContext) cc(cc *closeContext) {
case PARENT:
w = node
name = m.pstr(d.dependency)
case EVAL:
if cc.Label().IsLet() {
// Do not show eval links for let nodes, as they never depend
// on the parent node. Alternatively, link them to the root
// node instead.
return
}
fallthrough
case ARC, NOTIFY, DISJUNCT, COMP:
case EVAL, ARC, NOTIFY, DISJUNCT, COMP:
w = global
indentLevel = 1
name = m.pstr(d.dependency)
Expand Down

0 comments on commit 2e312df

Please sign in to comment.