Skip to content

Commit

Permalink
cuepls: slim down to single format command
Browse files Browse the repository at this point in the history
For now we are maintaining cmd/cuepls as a separate binary from cmd/cue.
In later changes we might merge the former into the latter to create a
single entry point for doing all things CUE. Doing so will require quite
a lot of open heart surgery on cmd/cuepls, to adapt/move away from the
existing flag-based approach to commands and subcommands. cmd/cue (as a
reminder) uses cobra, and the two are not compatible at least as far as
UX is concerned. It also complicates code/flag handling.

In order to create a minimal working end-to-end cuepls command with
integration tests, we only need a serve command for now. Therefore
remove all other commands to limit the surface area of cmd/cuepls
exposed.

For #142

Signed-off-by: Paul Jolly <[email protected]>
Change-Id: Ic6e6d933a12d43a1fee69a7505eaaf23870a453f
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1174169
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>
  • Loading branch information
myitcv committed Feb 14, 2024
1 parent 821973b commit 3e7e903
Show file tree
Hide file tree
Showing 20 changed files with 0 additions and 2,235 deletions.
143 changes: 0 additions & 143 deletions internal/golangorgx/gopls/cmd/call_hierarchy.go

This file was deleted.

73 changes: 0 additions & 73 deletions internal/golangorgx/gopls/cmd/check.go

This file was deleted.

20 changes: 0 additions & 20 deletions internal/golangorgx/gopls/cmd/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -277,29 +277,9 @@ func (app *Application) internalCommands() []tool.Application {

func (app *Application) featureCommands() []tool.Application {
return []tool.Application{
&callHierarchy{app: app},
&check{app: app},
&codelens{app: app},
&definition{app: app},
&execute{app: app},
&foldingRanges{app: app},
&format{app: app},
&highlight{app: app},
&implementation{app: app},
&imports{app: app},
newRemote(app, ""),
newRemote(app, "inspect"),
&links{app: app},
&prepareRename{app: app},
&references{app: app},
&rename{app: app},
&semtok{app: app},
&signature{app: app},
&stats{app: app},
&suggestedFix{app: app},
&symbols{app: app},

&workspaceSymbol{app: app},
}
}

Expand Down
138 changes: 0 additions & 138 deletions internal/golangorgx/gopls/cmd/codelens.go

This file was deleted.

Loading

0 comments on commit 3e7e903

Please sign in to comment.