Skip to content

Commit

Permalink
cue: ignore some tests for TestPos
Browse files Browse the repository at this point in the history
The new evalautor reports different, but correct,
positions, that are actually better than those of
the old evaluator.

Issue #3060

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: I56d062eec11d22f5eac1fe8751071cd9f0fbb9a9
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194057
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>
  • Loading branch information
mpvl committed Apr 30, 2024
1 parent fa3bf5f commit 71220e6
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion cue/types_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3235,6 +3235,7 @@ func TestPos(t *testing.T) {
testCases := []struct {
value string
pos string
skip bool
}{{
value: `
a: string
Expand All @@ -3245,6 +3246,10 @@ a: "foo"`,
a: x: string
a: x: "x"`,
pos: "2:4",

// the position of the new evaluator is also correct, and actually
// better.
skip: true,
}, {
// Prefer struct conjuncts with actual fields.
value: `
Expand All @@ -3264,7 +3269,9 @@ a: x: y: z: "x"`,
}}
for _, tc := range testCases {
runMatrix(t, "", func(t *testing.T, cfg *evalConfig) {
TODO_V3(t, cfg)
if tc.skip {
TODO_V3(t, cfg)
}

var c Context
(*runtime.Runtime)(&c).Init()
Expand Down

0 comments on commit 71220e6

Please sign in to comment.