Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/toml: support encoding and decoding comments #3342

Open
mvdan opened this issue Jul 30, 2024 · 0 comments
Open

encoding/toml: support encoding and decoding comments #3342

mvdan opened this issue Jul 30, 2024 · 0 comments
Assignees
@mvdan
Labels
encoding

Comments

@mvdan
Copy link
Member

mvdan commented Jul 30, 2024

Right now, the TOML encoding discards comments both when encoding CUE and decoding into CUE. We should support them on a best-effort basis in both cases, much like how the YAML decoder already supports comments.
@mvdan mvdan added the encoding label Jul 30, 2024
This was referenced Jul 30, 2024
Open
Closed
@mvdan mvdan self-assigned this Aug 14, 2024
@mvdan mvdan mentioned this issue Aug 20, 2024
Open
cueckoo pushed a commit that referenced this issue Aug 22, 2024
@mvdan
cmd/cue: add testscript to cover exporting CUE comments
d2ce0e3 
Much like encoding_empty.txtar, this is a high-level test for cmd/cue's
ability to export CUE comments in different encodings, including to CUE.

For #1180.
For #3342.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I306c16d590b9c1faa45f8e083d094838cf9635ed
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1199689
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Paul Jolly <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvdan mvdan

Labels
encoding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvdan