fix(format): indent list elements correctly #2645
Conversation
Vertical tabs are not inserted when the next expression needs a form feed, but are erroneously inserted for expressions which hide the underlying type. This is fixed by recursively checking if expressions need a form feed. Fixes: cue-lang#2314 Signed-off-by: Thomas Way <[email protected]>
There was a problem hiding this comment.
This does mean that we vertically align fields in fewer cases, but some of those were clearly broken like you show, so this definitely seems like a good step.
We can always tweak the heuristic to vertically align more often again in the future, bearing in mind to not break your added test cases.
|
Imported this PR into Gerrit as https://review.gerrithub.io/c/cue-lang/cue/+/1170966, since GitHub is a git mirror. I can't review commit messages on GitHub PRs like on Gerrit, so I took the liberty to expand your commit message a bit to explain what I think is going on with the problem and your fix. Hope that's okay. You can always leave a review on the Gerrit CL if you would like it written differently :) |
|
Also FYI, CI failed since |
Vertical tabs are not inserted when the next expression needs a form feed, but are erroneously inserted for expressions which hide the underlying type. This is fixed by recursively checking if expressions need a form feed.
Fixes: #2314