-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Homepage and some subdirectories to Chinese #217
Conversation
✔️ Deploy Preview for cue ready! 🔨 Explore the source changes: f0dc867 🔍 Inspect the deploy log: https://app.netlify.com/sites/cue/deploys/622aa15c06f4410009d616f3 😎 Browse the preview: https://deploy-preview-217--cue.netlify.app |
@h1z3y3 this is fantastic, thank you! Apologies for the delay, we've been busy preparing for our FOSDEM talk tomorrow I've just merged a PR that will mean you need to rebase here, but then the CI tests should pass (it's a check that ensures this repo is up-to-date with the latest stable CUE version). Please can you ensure that PRs only have a single commit? We do squash merging on this project in order to keep a clean linear git history. It also ensures we have a good commit message log from which you can tell what went into each change. Have a look at the main project commit history for example: https://github.com/cue-lang/cue/commits/master Tips on good commit messages can be found in the contribution guide: https://github.com/cue-lang/cue/blob/master/doc/contribute.md#good-commit-messages Not sure if you are familiar with Gerrit, but we also have plans to migrate this repository to use https://gerrithub.io/. That will allow us to do reviews in Gerrit or GitHub, whichever you prefer. Any problems/questions, please feel free to ping me on Slack if DM is quicker/easier/more immediate. |
d5337fb
to
48bfe2d
Compare
b40bedf
to
a2f95a6
Compare
Thanks for your reply too!
That's cool !!
I've rebased the master and merged #219 and #220, therefore you can close both of them.
Don't worry about this, I've read the contribute guideline before and I always follow it with one commit in each PR.
I've never used Gerrit, but I will learn about it.
So kind of you, and I was so moved after I translated our Code of Conduct. |
db9e686
to
211305d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1z3y3 my sincere apologies for the delays in reviewing here. Thank you for your patience.
Happy to chat on Slack in case I've got any of the translation wrong in my review.
ece2e8d
to
f1e613b
Compare
@myitcv |
6dd8a22
to
1bfe964
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1z3y3 thank you again for your patience whilst I was travelling. Once again, please excuse my use of the DeepL translator - it is the best/only reference I have for now!
@h1z3y3 please let me know when you'd like me to take another look at this. I see you have pushed another commit, but generally wait for something like "PTAL" (which is used in the Go project - it stands for "Please Take A Look") |
Sorry for my late reply ! PTAL |
What’s updated: 1. Translate homepage to Chinese 2. Translate /install and /contribution_guidelines to Chinese Signed-off-by: hezhaoyang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @h1z3y3 thank you VERY much for your initiative to make this happen, and then patience as we worked through the review.
No, I thank you. Thanks for your all works on CUE. 👍 |
🎉 The homepage supports Chinese now.
But I didn't add any document pages, so I use the original English links on the Chinese homepage.I will translate the documents page step by step and add them in the near future.Merge #219 and #220
What's updated:
Relate with: cue-lang/cue#970
Close #219 and #220