Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Homepage and some subdirectories to Chinese #217

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

h1z3y3
Copy link
Contributor

@h1z3y3 h1z3y3 commented Jan 26, 2022

🎉 The homepage supports Chinese now.

But I didn't add any document pages, so I use the original English links on the Chinese homepage.
I will translate the documents page step by step and add them in the near future.

Merge #219 and #220

What's updated:

  1. Translate homepage to Chinese
  2. Translate /install and /contribution_guidelines to Chinese

Relate with: cue-lang/cue#970

Close #219 and #220

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for cue ready!

🔨 Explore the source changes: f0dc867

🔍 Inspect the deploy log: https://app.netlify.com/sites/cue/deploys/622aa15c06f4410009d616f3

😎 Browse the preview: https://deploy-preview-217--cue.netlify.app

@myitcv
Copy link
Member

myitcv commented Feb 4, 2022

@h1z3y3 this is fantastic, thank you!

Apologies for the delay, we've been busy preparing for our FOSDEM talk tomorrow

I've just merged a PR that will mean you need to rebase here, but then the CI tests should pass (it's a check that ensures this repo is up-to-date with the latest stable CUE version).

Please can you ensure that PRs only have a single commit? We do squash merging on this project in order to keep a clean linear git history. It also ensures we have a good commit message log from which you can tell what went into each change. Have a look at the main project commit history for example:

https://github.com/cue-lang/cue/commits/master

Tips on good commit messages can be found in the contribution guide:

https://github.com/cue-lang/cue/blob/master/doc/contribute.md#good-commit-messages

Not sure if you are familiar with Gerrit, but we also have plans to migrate this repository to use https://gerrithub.io/. That will allow us to do reviews in Gerrit or GitHub, whichever you prefer.

Any problems/questions, please feel free to ping me on Slack if DM is quicker/easier/more immediate.

@h1z3y3 h1z3y3 force-pushed the chinese_edition branch 3 times, most recently from d5337fb to 48bfe2d Compare February 5, 2022 14:16
@h1z3y3 h1z3y3 changed the title feat: Make Chinese Homepage Translate Chinese Homepage, /install/*, and /contribution_guidelines/* Feb 5, 2022
@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Feb 5, 2022

@h1z3y3 this is fantastic, thank you!

Thanks for your reply too!

Apologies for the delay, we've been busy preparing for our FOSDEM talk tomorrow

That's cool !!
BTW, will it be published on CUE Youtube channel? If it will be, I'll appreciate it.

I've just merged a PR that will mean you need to rebase here, but then the CI tests should pass (it's a check that ensures this repo is up-to-date with the latest stable CUE version).

I've rebased the master and merged #219 and #220, therefore you can close both of them.

Please can you ensure that PRs only have a single commit? We do squash merging on this project in order to keep a clean linear git history. It also ensures we have a good commit message log from which you can tell what went into each change. Have a look at the main project commit history for example:

https://github.com/cue-lang/cue/commits/master

Tips on good commit messages can be found in the contribution guide:

https://github.com/cue-lang/cue/blob/master/doc/contribute.md#good-commit-messages

Don't worry about this, I've read the contribute guideline before and I always follow it with one commit in each PR.

Not sure if you are familiar with Gerrit, but we also have plans to migrate this repository to use https://gerrithub.io/. That will allow us to do reviews in Gerrit or GitHub, whichever you prefer.

I've never used Gerrit, but I will learn about it.

Any problems/questions, please feel free to ping me on Slack if DM is quicker/easier/more immediate.

So kind of you, and I was so moved after I translated our Code of Conduct.
We don't have too many conversations, but I still really feel you're friendly and welcomely.

@h1z3y3 h1z3y3 changed the title Translate Chinese Homepage, /install/*, and /contribution_guidelines/* Translate Chinese Homepage and some subdirectories Feb 5, 2022
@h1z3y3 h1z3y3 changed the title Translate Chinese Homepage and some subdirectories Translate Homepage and some subdirectories to Chinese Feb 5, 2022
@h1z3y3 h1z3y3 force-pushed the chinese_edition branch 2 times, most recently from db9e686 to 211305d Compare February 10, 2022 10:50
@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Feb 10, 2022

@myitcv
I update the contents according to the changes of #224 and #225

Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1z3y3 my sincere apologies for the delays in reviewing here. Thank you for your patience.

Happy to chat on Slack in case I've got any of the translation wrong in my review.

content/en/_index.html Outdated Show resolved Hide resolved
content/en/_index.html Outdated Show resolved Hide resolved
content/zh/docs/contribution_guidelines/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribution_guidelines/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribution_guidelines/conduct.md Outdated Show resolved Hide resolved
content/zh/docs/contribution_guidelines/conduct.md Outdated Show resolved Hide resolved
@h1z3y3 h1z3y3 force-pushed the chinese_edition branch 2 times, most recently from ece2e8d to f1e613b Compare February 23, 2022 09:23
@h1z3y3 h1z3y3 requested a review from myitcv February 23, 2022 09:40
@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Feb 23, 2022

@myitcv
I'm very impressed with you and your work on this PR.
Thanks for your patience and kindness. I'm glad to have the opportunity of working with you. 😄

@h1z3y3 h1z3y3 force-pushed the chinese_edition branch 2 times, most recently from 6dd8a22 to 1bfe964 Compare February 28, 2022 09:59
Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1z3y3 thank you again for your patience whilst I was travelling. Once again, please excuse my use of the DeepL translator - it is the best/only reference I have for now!

content/zh/_index.html Show resolved Hide resolved
content/zh/_index.html Outdated Show resolved Hide resolved
content/zh/_index.html Outdated Show resolved Hide resolved
content/zh/pkg.go.dev.md Outdated Show resolved Hide resolved
content/zh/gen.go Outdated Show resolved Hide resolved
content/zh/docs/contribution_guidelines/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribution_guidelines/conduct.md Outdated Show resolved Hide resolved
content/zh/docs/contribution_guidelines/conduct.md Outdated Show resolved Hide resolved
@myitcv
Copy link
Member

myitcv commented Mar 7, 2022

@h1z3y3 please let me know when you'd like me to take another look at this. I see you have pushed another commit, but generally wait for something like "PTAL" (which is used in the Go project - it stands for "Please Take A Look")

@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Mar 8, 2022

Sorry for my late reply ! PTAL

    What’s updated:
    1. Translate homepage to Chinese
    2. Translate /install and /contribution_guidelines to Chinese

Signed-off-by: hezhaoyang <[email protected]>
@h1z3y3 h1z3y3 requested a review from myitcv March 11, 2022 01:24
Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @h1z3y3 thank you VERY much for your initiative to make this happen, and then patience as we worked through the review.

@myitcv myitcv merged commit 6a4aeae into cue-lang:master Mar 12, 2022
@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Mar 13, 2022

No, I thank you. Thanks for your all works on CUE. 👍
It's my pleasure to bring such powerful CUE to Chinese developer. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants