add regex to support comment inside string like http://example.com #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @fabricematrat. I'll have a look at this soon. Hopefully @unscriptable can take a look, too, since he did a lot of the more recent work on the builder. |
|
This is looking pretty good to me. I love that you separated out part of the parsing so it is testable. Any concerns, @unscriptable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
To be able to support 'http://example.com' inside the template, cram should avoid to take it as a comment.
The current behavior of cram will create an invalid file with 'http: and then the next line.
I implemented a regexp which replace the string containing comments (// or /.../) by a temp variable and store it in an array. Then call the same logic of removing comment, then put back the original string.
BR,
Fabrice.