Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checking for Subscription initialization #383

Conversation

KoenLav
Copy link

@KoenLav KoenLav commented Oct 6, 2021

This allows us to recognize the Subscription is initialized and then disregard our Tenant check only for those (we apply the Tenant check on the Client as well, so this works for us but isn't really safe).

We also noticed that Meteor.userId() (nor this.userId) can be accessed within the configureRedisOplog cursor function (used for applying the Tenant namespace to a Collection), so I believe this is currently broken (at least for initializing (Redis Oplog-based) Subscriptions).

Hence I think this PR should be seen as further outlining the issue, and discussing possible directions for a solution.

@KoenLav
Copy link
Author

KoenLav commented Oct 6, 2021

Relates to: #369

@StorytellerCZ StorytellerCZ added this to the V2.2 milestone Oct 7, 2022
@StorytellerCZ StorytellerCZ linked an issue Oct 7, 2022 that may be closed by this pull request
6 tasks
@StorytellerCZ
Copy link
Collaborator

@KoenLav can you please add some docs for this. Tests if possible. Thank you!

@StorytellerCZ StorytellerCZ reopened this May 30, 2023
@StorytellerCZ StorytellerCZ modified the milestones: V2.2, V2.3 Jun 10, 2023
@KoenLav
Copy link
Author

KoenLav commented Feb 26, 2024

@StorytellerCZ I've added some docs and tests.

Edit: not sure why the test is failing?

@KoenLav KoenLav closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meteor.userId can only be invoked in method calls or publications.
2 participants