fix: issue with collection hooks #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing-subscription-initialization
…nitialization Allow checking subscription initialization
Instead the code now checks for a `direct` field on collections and uses that to do lookups; bypassing the (possible) collection hooks
jdgjsag67251
commented
Apr 10, 2024
| @@ -164,6 +164,9 @@ class RedisSubscriptionManager { | |||
| debug( | |||
| `[RedisSubscriptionManager] Exception while processing event: ${e.toString()}` | |||
| ); | |||
| Meteor._debug( | |||
There was a problem hiding this comment.
Previously these were just swallowed when debug was not turned on
jdgjsag67251
changed the title
KoenLav
approved these changes
Apr 10, 2024
|
Any chance of fixing the tests? |
|
BTW, when I tried running the tests locally I ran into a syntax error in Chai because it uses some JS features that are not available in Node v14. I installed |
|
Once the tests pass I will release it as a patch. |
|
@jdgjsag67251 some issues still remain. |
Yeah looks like the issue I had with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package performs multiple
findoperations. This can cause issues when the Meteor collection hooks package is installed; since this can add restrictions on the selectors which may prevent updates from being sent.This PR just adds a check if the
directkey is available, if so it will use that for all internalfindoperations.