-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support css modules in storybook #4931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it in storybook to reduce crossover deps
🦋 Changeset detectedLatest commit: 2da5bdd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…amp/kaizen-design-system into support-css-modules-in-storybook
…amp/kaizen-design-system into support-css-modules-in-storybook
HeartSquared
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Storybook's existing config to process styles is outdated and cannot support both SCSS and CSS modules at the same time.
What
Notes
The DST has had conversations about using
next-storybook
to remain consistent with the rest of the business however the DS goals require much less config (and support for different config eg. MDX) than the rest of the business, which could lead to slower development time.Also on the note of config, the
next-storybook
makes heavy use of custom plugins, due to the complexity it has been difficult to upgrade it to newer versions and config syntax, namely the move to ESM which will take some time to resolve all dependencies which don't support ESM. So if Kaizen were to adopt this technology, we'd potentially lose out on benefits which could improve our productivity.That isn't to say we shouldn't ever adopt
next-storybook
just that this isn't the right time to do it as we don't gain very much for the time invested in potentially upgrading it ourselves. Eventually I can see thenext-storybook
becoming simpler as it no longer needs to cater for things like excluding/including packages for processing styles.