Add renderer component for itk-viewer-2d custom element #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevejpurves I think all that is left TODO is
|
PaulHax
changed the title
|
@PaulHax thanks for the ping! let me try and take this over the line, will be able to get some time on it tomorrow |
|
Heyo @stevejpurves Is there anything I can do to help out here. (I know this viewer of ours has a few integration rough edges...) |
|
@PaulHax sorry i got swamped - Are you at scipy? maybe we could hack on this there? |
|
Hi @stevejpurves, I am traveling to SciPy tomorrow; we would love to work with you on this. We might be able to bring in Paul remotely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a stab at what the itk-viewer renderer plugin would look like. Based the
viewer.tsxandviewer.client.tsxon this working test getting itk-viewer going in a Remix CRA base project. PaulHax/remix-itk-viewer-example@bfc0f41related to #1