Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables are overwritten with update #2

Closed
Ernst79 opened this issue Nov 26, 2019 · 2 comments · Fixed by #6
Closed

Variables are overwritten with update #2

Ernst79 opened this issue Nov 26, 2019 · 2 comments · Fixed by #6
Assignees
Labels
bug Something isn't working

Comments

@Ernst79
Copy link
Collaborator

Ernst79 commented Nov 26, 2019

Updating with HACS will overwrite the variables in sensor.py. These should be moved to configuration.yaml.

I will work on this coming days.

@Magalex2x14 can you let me know what can be taken as constants and what you want in configuration.yaml? I think the limits do not have to be in configuration.yaml, am I right?

@Ernst79 Ernst79 added the bug Something isn't working label Nov 26, 2019
@Ernst79 Ernst79 self-assigned this Nov 26, 2019
@Magalex2x14
Copy link
Collaborator

Yes. I think, only limits can be left as constants. Other options it would be nice to have in the configuration.yaml.

@Ernst79
Copy link
Collaborator Author

Ernst79 commented Nov 26, 2019

My first attempt to get the variables to the configuration failed, can't figure out why. So, I decided to start over.

Luckily, the second attempt succeeded, I can now use configuration.yaml for the decimals option. Will add the rest tomorrow, should be easy now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants