generated from ludeeus/integration_blueprint
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW FEATURE] Add addons to available variables #15
Merged
ludeeus
merged 6 commits into
custom-components:master
from
l-j:feature/add-addons-to-available-variables
May 28, 2022
Merged
[NEW FEATURE] Add addons to available variables #15
ludeeus
merged 6 commits into
custom-components:master
from
l-j:feature/add-addons-to-available-variables
May 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiner66
approved these changes
Jan 16, 2022
shiner66
approved these changes
Jan 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works correctly on my installation
@ludeeus Can you take a look? |
ludeeus
requested changes
Feb 20, 2022
l-j
force-pushed
the
feature/add-addons-to-available-variables
branch
from
February 23, 2022 18:27
a6e222b
to
cdd7f75
Compare
Co-authored-by: Joakim Sørensen <[email protected]>
l-j
force-pushed
the
feature/add-addons-to-available-variables
branch
from
February 23, 2022 18:52
cdd7f75
to
bc3b2c5
Compare
I have tested changes again against Home Assistant 2022.2.9 and HACS 1.22.0. @ludeeus can you re-check? |
@ludeeus can you re-check? |
ludeeus
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it will be beneficial to add to this component a possibility to list not only HACS components, but Home Assistant add-ons also. That way it will be possible for a user of the plugin to have a list of all extensions (HACS Integrations, plugins, themes and Home Assistant Add-ons) in one place, for example as a part of the documentation for Home Assistant configuration (this is how I am using it).
In this PR I updated README and the default template as well, so it will be more clear for others, what are the capabilities of this component.
Tested on Home Assistant 2021.12.8, HACS 0.19.2.