Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW FEATURE] Add addons to available variables #15

Merged

Conversation

l-j
Copy link
Contributor

@l-j l-j commented Jan 10, 2022

I think it will be beneficial to add to this component a possibility to list not only HACS components, but Home Assistant add-ons also. That way it will be possible for a user of the plugin to have a list of all extensions (HACS Integrations, plugins, themes and Home Assistant Add-ons) in one place, for example as a part of the documentation for Home Assistant configuration (this is how I am using it).

In this PR I updated README and the default template as well, so it will be more clear for others, what are the capabilities of this component.

Tested on Home Assistant 2021.12.8, HACS 0.19.2.

Copy link

@shiner66 shiner66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly on my installation

@l-j
Copy link
Contributor Author

l-j commented Feb 2, 2022

@ludeeus Can you take a look?

custom_components/readme/__init__.py Show resolved Hide resolved
custom_components/readme/__init__.py Show resolved Hide resolved
custom_components/readme/default.j2 Outdated Show resolved Hide resolved
custom_components/readme/default.j2 Outdated Show resolved Hide resolved
custom_components/readme/default.j2 Outdated Show resolved Hide resolved
custom_components/readme/__init__.py Outdated Show resolved Hide resolved
custom_components/readme/__init__.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@l-j l-j force-pushed the feature/add-addons-to-available-variables branch from a6e222b to cdd7f75 Compare February 23, 2022 18:27
Co-authored-by: Joakim Sørensen <[email protected]>
@l-j l-j force-pushed the feature/add-addons-to-available-variables branch from cdd7f75 to bc3b2c5 Compare February 23, 2022 18:52
@l-j l-j requested a review from ludeeus February 23, 2022 18:53
@l-j
Copy link
Contributor Author

l-j commented Feb 23, 2022

I have tested changes again against Home Assistant 2022.2.9 and HACS 1.22.0.

@ludeeus can you re-check?

@l-j
Copy link
Contributor Author

l-j commented Mar 24, 2022

@ludeeus can you re-check?

@ludeeus ludeeus merged commit 208ae25 into custom-components:master May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants