feat: added setting notification center delegate as configurable prop…

…erty (#92)
customerio · Jul 13, 2023 · 89ff34e · 89ff34e
1 parent 3423dcc
commit 89ff34e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/helpers/constants/ios.ts b/src/helpers/constants/ios.ts
@@ -54,7 +54,7 @@ export const CIO_DIDREGISTERFORREMOTENOTIFICATIONSWITHDEVICETOKEN_SNIPPET = `
 
 export const CIO_CONFIGURECIOSDKPUSHNOTIFICATION_SNIPPET = `
   // Register for push notifications
-  [pnHandlerObj registerPushNotification:self];
+  [pnHandlerObj registerPushNotification];
 `;
 
 export const CIO_CONFIGURECIOSDKUSERNOTIFICATIONCENTER_SNIPPET = `
@@ -75,11 +75,10 @@ export const CIO_WILLPRESENTNOTIFICATIONHANDLER_SNIPPET = `
   completionHandler( UNNotificationPresentationOptionAlert + UNNotificationPresentationOptionSound);
 }`;
 export const CIO_REGISTER_PUSHNOTIFICATION_SNIPPET = `
-@objc(registerPushNotification:)
-  public func registerPushNotification(withNotificationDelegate notificationDelegate: UNUserNotificationCenterDelegate) {
+@objc(registerPushNotification)
+  public func registerPushNotification() {
 
     let center  = UNUserNotificationCenter.current()
-    center.delegate = notificationDelegate
     center.requestAuthorization(options: [.sound, .alert, .badge]) { (granted, error) in
       if error == nil{
         DispatchQueue.main.async {

diff --git a/src/ios/withAppDelegateModifications.ts b/src/ios/withAppDelegateModifications.ts
@@ -179,7 +179,12 @@ export const withAppDelegateModifications: ConfigPlugin<
       ) {
         stringContents = addNotificationConfiguration(stringContents);
       }
-      stringContents = addUserNotificationCenterConfiguration(stringContents);
+      if (
+        props.handleNotificationSetup !== undefined &&
+        props.handleNotificationSetup === false
+      ) {
+        stringContents = addUserNotificationCenterConfiguration(stringContents);
+      }
       stringContents = addAdditionalMethodsForPushNotifications(stringContents);
       stringContents =
         addDidFailToRegisterForRemoteNotificationsWithError(stringContents);

diff --git a/src/types/cio-types.ts b/src/types/cio-types.ts
@@ -16,6 +16,7 @@ export type CustomerIOPluginOptionsIOS = {
   appleTeamId?: string;
   appName?: string;
   disableNotificationRegistration?: boolean;
+  handleNotificationSetup?:boolean;
   useFrameworks?: 'static' | 'dynamic';
   pushNotification?: {
     useRichPush: boolean;