fix: expo-doctor plugin error #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengfred
approved these changes
Oct 25, 2024
Shahroz16
approved these changes
Oct 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
## [1.0.0-beta.16](1.0.0-beta.15...1.0.0-beta.16) (2024-10-25) ### Bug Fixes * expo-doctor plugin error ([#154](#154)) ([5b2adb3](5b2adb3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear ticket: https://linear.app/customerio/issue/MBL-611/plugin-not-found-error-running-expo-doctor-1101
Problem:
Customers are facing an issue where the
npx expo-doctorcommand fails with the errorPLUGIN_NOT_FOUNDwhen using the Customer.io Expo plugin. The customers reported that they do have the plugin rightly installed and can find it in
node_modulesbut still see the error on running the command hence becoming a blocker for the customers.Solution:
This PR makes sure to include
app.plugin.json installing the customerio-expo-plugin in a customer app so that on running npx expo-doctor the file is found and the customers no longer see the error.Testing:
Before the fix:
PluginError: Failed to resolve plugin for module "customerio-expo-plugin" relative to "/Users/xxx/xxxx/xxxxx"After the fix:
expo-doctor runs successfully.