Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xcode race condition fix #76

Merged
merged 9 commits into from
Jun 1, 2023
Merged

fix: xcode race condition fix #76

merged 9 commits into from
Jun 1, 2023

Conversation

xtreem88
Copy link
Contributor

@xtreem88 xtreem88 commented May 19, 2023

Resolves #72
Partially resolves: https://github.com/customerio/issues/issues/10195
Build on the changes in #73

Changes

  • Used withXcodeProject to modify project.pbxproj instead of xcode package

Testing instruction

  • Install the plugin
  • run rebuild and then build (on local and EAS) and run
  • Make sure push rich push and all other features work as extected

@github-actions
Copy link

github-actions bot commented May 19, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@xtreem88 xtreem88 changed the title fir fix May 19, 2023
…thub.com:euc-callum/customerio-expo-plugin into xcode-race-condition-fix
…io/customerio-expo-plugin into xcode-race-condition-fix"

This reverts commit a6d0fd2, reversing
changes made to 1e87a1d.
@xtreem88 xtreem88 changed the title fix fix: xcode race condition fix May 25, 2023
@xtreem88 xtreem88 marked this pull request as ready for review May 25, 2023 19:25
Copy link
Contributor

@euc-callum euc-callum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@sergey-king
Copy link

any updates on when this will get merged?

@xtreem88
Copy link
Contributor Author

@sergey-king It is currently in QA awaiting approval, it should be merged today if everything goes well.

@xtreem88 xtreem88 merged commit ff136ba into beta Jun 1, 2023
@xtreem88 xtreem88 deleted the xcode-race-condition-fix branch June 1, 2023 11:32
github-actions bot pushed a commit that referenced this pull request Jun 1, 2023
## [1.0.0-beta.10](1.0.0-beta.9...1.0.0-beta.10) (2023-06-01)

### Bug Fixes

* xcode race condition fix ([#76](#76)) ([ff136ba](ff136ba))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Customer.IO overwrites project file changes from other plugins
4 participants