pr suggestions

customerio · Sep 10, 2024 · 60a268d · 60a268d
1 parent be36659
commit 60a268d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/ios/wrappers/logging/CioLoggingEmitter.swift b/ios/wrappers/logging/CioLoggingEmitter.swift
@@ -36,7 +36,7 @@ class CioLoggingEmitter: RCTEventEmitter {
 
 class CioLoggerWrapper: CioLogger {
     private(set) var logLevel: CioLogLevel
-    private var moduleRegistry: RCTModuleRegistry
+    private weak var moduleRegistry: RCTModuleRegistry?
 
     static func getInstance (moduleRegistry: RCTModuleRegistry, logLevel: CioLogLevel) -> CioLogger {
         if let wrapper = DIGraphShared.shared.logger as? Self  {
@@ -90,7 +90,7 @@ class CioLoggerWrapper: CioLogger {
     }
 
     private var emitter: CioLoggingEmitter? {
-        moduleRegistry.module(forName: "CioLoggingEmitter") as? CioLoggingEmitter
+        moduleRegistry?.module(forName: "CioLoggingEmitter") as? CioLoggingEmitter
     }
 
 }
diff --git a/src/native-logger-listener.ts b/src/native-logger-listener.ts
@@ -19,8 +19,10 @@ const CioLoggingEmitter = NativeModules.CioLoggingEmitter
     );
 
 export class NativeLoggerListener {
+
   static initialize() {
     const bridge = new NativeEventEmitter(CioLoggingEmitter);
+    const loggerPrefix = "[CIO] ";
     bridge.addListener(
       'CioLogEvent',
       (event: { logLevel: CioLogLevel; message: string }) => {
@@ -31,16 +33,16 @@ export class NativeLoggerListener {
         async function log() {
           switch (event.logLevel) {
             case CioLogLevel.Debug:
-              console.debug("[CIO] " + event.message);
+              console.debug(loggerPrefix + event.message);
               break;
             case CioLogLevel.Info:
-              console.info("[CIO] " + event.message);
+              console.info(loggerPrefix + event.message);
               break;
             case CioLogLevel.Error:
-              console.error("[CIO] " + event.message);
+              console.error(loggerPrefix + event.message);
               break;
             default:
-              console.log("[CIO] " + event);
+              console.log(loggerPrefix + event);
               break;
           }
         }