chore: logging feature in android native module #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Shahroz16
approved these changes
Sep 10, 2024
android/src/main/java/io/customer/reactnative/sdk/logging/CustomerIOReactNativeLogger.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/io/customer/reactnative/sdk/logging/CustomerIOReactNativeLogger.kt
Outdated
Show resolved
Hide resolved
ami-aman
merged commit 1b29f29
into
feature/cdp-milestone-track-identify
2 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear ticket: https://linear.app/customerio/issue/MBL-478/add-logging-support-in-package-android-native-module
Problem
As a developer, I want to have logging support integrated into the package so that I can easily access logs without needing to open Android Studio as we do today.
Solution
Added logger support in React Native using event emitters from the Android native module, enabling all native logs to be output to the React Native console. This eliminates the need for customers to open Xcode to retrieve logs, as they currently do.
This is the screenshot from VS Code when loglevel is debug.
