Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register contexts at construct time #35

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kevinkucharczyk
Copy link
Collaborator

This PR makes the addon register context when components get instantiated, rather than on first render.

This has two benefits:

  • components can initialize state that depends on parent contexts without having to wait for the first render
  • a component can consume and provide the same context key without infinite reference errors: consume would read the existing context "above" the component, while provide would provide a new context to any nested children

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 136df37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ember-provide-consume-context Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants