Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to load patch from specific package #417

Closed
wants to merge 1 commit into from

Conversation

johannes85
Copy link

This changes allows to load the patch from a specific packageb by defining its location in the following way: //package/name//patch/to/patch

For example:

"extra": {
        "patches": {
            "xp-framework/core": {
                "Safer Objects::stringOf": "//my/package//src/main/patches/xp-framework-core-src-main-php-util-objects-class-php.patch"
            }
        }
    },

I implemented this change because when you define a local patch file in a package like "patches/patch1.patch" the installation of this patch only works when executing composer in the package itself. When the package is a dependency of a project( with "enable-patching"), the patch file can't be found since the current root directory is another one.

@cweagans
Copy link
Owner

cweagans commented Feb 4, 2023

Probably not going to do this in 1.x, and 2.x doesn't have the idea of resolving patches from dependencies.

@cweagans cweagans closed this Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants