Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an environment variable to docker file, fixing -td flag and catching exceptions and adding tag to docker image #45

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

2niknatan
Copy link
Contributor

Fixing -dt flag
Adding environment variable to docker file and changing the code accordingly
Handling exceptions so the program will not crush.
Adding a tag to the docker image the 'docker_run.sh' script.

Desired Outcome

Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.

Implemented Changes

Adding environment variable and changing 'running_in_container' function.
Adding try and catch to possible functions that throw exceptions.
Adding a tag to the docker image the 'docker_run.sh' script.

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

…n_container' function accordingly.

 Handling exceptions so the program will not crush.
 Adding a tag to the 'docker run' command in the 'docker_run.sh' script.
@g3rzi g3rzi merged commit f3f83a2 into cyberark:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants