Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout option to authentication module #48

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

mrendo
Copy link
Contributor

@mrendo mrendo commented Nov 4, 2022

Desired Outcome

We noticed now we have turned on two factor we have a problem with the module timing out before we have pressed the push notification.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

Adding a timeout option to the authentication module, tested it using a local copy of the module with my Cyberark system

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76] #47

CyberArk internal issue link: insert issue ID

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

Copy link
Member

@infamousjoeg infamousjoeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After bumping version to 1.0.16 this looks good to me and can be merged.

galaxy.yml Outdated Show resolved Hide resolved
@infamousjoeg
Copy link
Member

Will merge and publish to Galaxy in the morning.

@infamousjoeg infamousjoeg merged commit dcce173 into cyberark:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants