Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.17 #53

Merged
merged 2 commits into from
Jan 17, 2023
Merged

1.0.17 #53

merged 2 commits into from
Jan 17, 2023

Conversation

infamousjoeg
Copy link
Member

Desired Outcome

Release version 1.0.17 of the Ansible collection cyberark.pas.

Implemented Changes

  • Add sanity tests per Ansible Galaxy standards
  • Add aimprovider role

Connected Issue/Story

Resolves #44 #50

CyberArk internal issue ID: n/a

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@infamousjoeg
Fixes #44 sanity tests failing in cyberarkpas (#49)
f02ca61 
* Add sanity & integration tests

* Add master branch (legacy)

* Resolved all failing sanity tests

* Bump version to 1.0.17

* Add tests for Ansible 2.9 & ansible-base 2.10

* Resolve @felixfontein review comments

* no_log: False for Secrets Management parent

* Resolve @felixfontein review - rm needs units

* rm integration tests (for now)
@infamousjoeg
Add cyberark.aimprovider role to collection (#52)
d4f2efb
@infamousjoeg infamousjoeg self-assigned this Jan 17, 2023
@infamousjoeg infamousjoeg linked an issue Jan 17, 2023 that may be closed by this pull request
Release version 1.0.17 of this project #51
Closed
@infamousjoeg infamousjoeg merged commit cd5b39c into master Jan 17, 2023
@infamousjoeg infamousjoeg deleted the 1.0.17 branch January 17, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberark-bizdev cyberark-bizdev Awaiting requested review from cyberark-bizdev cyberark-bizdev is a code owner

Assignees

@infamousjoeg infamousjoeg

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release version 1.0.17 of this project Sanity tests failing in cyberark.pas
1 participant
@infamousjoeg