27 Fix goconvey build failure #28
Conversation
To support the newest version of goconvey that doesn't break our build, we needed to update our Dockerfile builds to Golang v1.13. Upstream: smartystreets/goconvey#600
Since the container goreleaser version changed, we needed to update the local version too. In the process: - Module metadata was cleaned up - Remnants of godep were removed (automatically)
sgnn7
force-pushed
the
27-fix-goconvey-failure
branch
from
ca5fd31
to
c3023aa
Compare
| @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] | |||
| ### Changed | |||
| - Upgraded build/test images to use Golang 1.13 instead of 1.11 ([#27](https://github.com/cyberark/summon-aws-secrets/issues/27)) | |||
There was a problem hiding this comment.
is this a user facing change? is there some value to the user that we should be calling out here?
There was a problem hiding this comment.
Yeah I added it intentionally because this is possibly a user-visible change because the binaries generated for releases may not behave 1:1 as expected between these versions. I can remove this if needed.
|
@sgnn7 we might have to revise the changelog message later, FYI. I think it should probably say something at the end like "Please note that since this upgrades the version of golang that we use to build the binaries to 1.13, the binaries generated for releases may not be exactly as before." but really, we should have tests to capture that so we have some assurance that this project isn't impacted by golang version bumps. |
|
Fair enough - I'll keep that in mind for future work. |
To support the newest version of goconvey that doesn't break our build,
we needed to update our Dockerfile builds to Golang v1.13. Small cleanup of
gomod/godep files was done as part of the change.
Fixes #27