Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.17; Remove GoConvey #54

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Update to go 1.17; Remove GoConvey #54

merged 1 commit into from
Dec 16, 2021

Conversation

szh
Copy link
Contributor

@szh szh commented Dec 16, 2021 •
edited
Loading

Use the latest major version of Go. Also remove GoConvey which removes some vulnerable dependencies.

Connected Issue/Story

N/A

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Dec 16, 2021
@szh szh marked this pull request as ready for review December 16, 2021 17:45
@szh szh requested a review from a team as a code owner December 16, 2021 17:45
@szh szh requested a review from andytinkham December 16, 2021 17:46
andytinkham
andytinkham approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szh szh merged commit 732a279 into main Dec 16, 2021
@szh szh deleted the golang-117 branch December 16, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytinkham andytinkham andytinkham approved these changes

Assignees

@szh szh

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szh @andytinkham