Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies for cucumber and aruba #239

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Update dependencies for cucumber and aruba #239

merged 1 commit into from
Oct 4, 2022

Conversation

juniortaeza
Copy link
Contributor

@juniortaeza juniortaeza commented Sep 28, 2022 •
edited
Loading

Desired Outcome

Resolves Cucumber's medium severity in Snyk for potential HTML injection in versions before 4.0

Implemented Changes

Updates acceptance/Gemfile.lock entirely to include most up-to-date versions of gems and dependencies

Connected Issue/Story

CyberArk internal issue link: CONJSE-1519

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@juniortaeza juniortaeza requested a review from a team as a code owner September 28, 2022 17:25
@rpothier
Copy link
Contributor

rpothier commented Oct 3, 2022

@adamouamani should we update to Cucumber 7?

@adamouamani
Copy link

@adamouamani should we update to Cucumber 7?

Thanks @rpothier Would be good to harmonize on version 7.1.0 of Cucumber which we use on other repo's

rpothier
rpothier suggested changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A minor comments, please add a new line at the end of Genfile.lock and squash the commits.

@juniortaeza
Copy link
Contributor Author

Looks good! A minor comments, please add a new line at the end of Genfile.lock and squash the commits.

sounds good! I'll also update the CHANGELOG as well. thank you!

@rpothier
Copy link
Contributor

rpothier commented Oct 3, 2022

Looks good, the changelog still says cucumber 4.x

@juniortaeza
Copy link
Contributor Author

Looks good, the changelog still says cucumber 4.x

ah, looks like I might've accidentally hit undo and saved. Fixed!

rpothier
rpothier approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juniortaeza juniortaeza merged commit 5777fa2 into main Oct 4, 2022
@juniortaeza juniortaeza deleted the update-branch branch October 4, 2022 14:35
@gl-johnson gl-johnson mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpothier rpothier rpothier approved these changes

Assignees

@juniortaeza juniortaeza

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juniortaeza @rpothier @adamouamani