Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] add Preset configs tab, closes #135 #136

Merged
merged 11 commits into from
Mar 15, 2023
Merged

Conversation

denys-holub
Copy link
Collaborator

Preset configs grid screenshot
image

@denys-holub denys-holub added epic Large body of work broken down into a number of smaller issues webui Admin UI related issues presets labels Mar 9, 2023
@denys-holub denys-holub added this to the Built-in WebUI milestone Mar 9, 2023
@denys-holub denys-holub self-assigned this Mar 9, 2023
@denys-holub denys-holub linked an issue Mar 9, 2023 that may be closed by this pull request
3 tasks
@denys-holub denys-holub changed the title add Preset configs tab, closes #135 [+] add Preset configs tab, closes #135 Mar 9, 2023
@pashagolub
Copy link
Collaborator

pashagolub commented Mar 9, 2023

Can we somehow make Config column more visual attractive? :-) We are doing fancy front end but not a terminal black box

Just an example: kpi db_size cpu

@denys-holub
Copy link
Collaborator Author

Can we somehow make Config column more visual attractive? :-)

I have one idea, I'll try it, but firstly I need to fix compiled warnings.

@denys-holub
Copy link
Collaborator Author

denys-holub commented Mar 13, 2023

@pashagolub

That's how I edited Config column.

image

For such view, I needed to set grid parameter rowHeight to auto. But I remember you said, that we don't need it. Without this parameter it looks like this.

image

Oh, and for that JSON parameters which are too long for badge, I added Popover.

image

@pashagolub pashagolub linked an issue Mar 13, 2023 that may be closed by this pull request
@denys-holub denys-holub marked this pull request as draft March 13, 2023 10:50
@denys-holub
Copy link
Collaborator Author

@pashagolub

That's how Config column looks like now.

image

And when you click Details button, dialog window opens.

image

And for configs with more parameters.

image

@pashagolub
Copy link
Collaborator

Nice. Works for me. We can think about wording later

@denys-holub denys-holub marked this pull request as ready for review March 14, 2023 13:00
@denys-holub denys-holub merged commit 8f0564c into master Mar 15, 2023
@denys-holub denys-holub deleted the 135-add-preset-configs-tab branch March 15, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Large body of work broken down into a number of smaller issues webui Admin UI related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for DELETE /preset?id={pc_name} endpoint add Preset configs tab
2 participants