Build mysql container image. #533
Merged
+605
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-kuro
force-pushed
the
d-kuro/mysqld-exporter-image
branch
from
483272a
to
6484587
Compare
d-kuro
force-pushed
the
d-kuro/mysqld-exporter-image
branch
from
6484587
to
7194029
Compare
d-kuro
force-pushed
the
d-kuro/mysqld-exporter-image
branch
from
7194029
to
fb8d2cb
Compare
d-kuro
force-pushed
the
d-kuro/mysqld-exporter-image
branch
from
fb8d2cb
to
4984f4b
Compare
d-kuro
force-pushed
the
d-kuro/mysqld-exporter-image
branch
2 times, most recently
from
6f11be8
to
bba493b
Compare
d-kuro
force-pushed
the
d-kuro/mysqld
branch
3 times, most recently
from
aa58594
to
b059e1d
Compare
d-kuro
force-pushed
the
d-kuro/mysqld-exporter-image
branch
2 times, most recently
from
8be7724
to
7768a77
Compare
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
d-kuro
commented
Jun 28, 2023
Comment on lines
+98
to
+99
| - name: Wait for MySQLCluster | ||
| run: kubectl wait -n default --for=condition=Available mysqlcluster/test --timeout=180s |
There was a problem hiding this comment.
Currently we are only testing until MySQLCluster is ready.
When the MySQL image is pushed to ghcr.io, we will rewrite the E2E manifests and modify it to run the E2E test using the built mysqld image.
https://github.com/cybozu-go/moco/blob/main/e2e/testdata/single.yaml#L26
masa213f
requested changes
Jul 5, 2023
containers/mysql/README.md
Outdated
| # MySQL container | ||
|
|
||
| This directory provides a Dockerfile to build a MySQL container for [MOCO](https://github.com/cybozu-go/moco). | ||
| This also provides `moco-init` command to initialize MySQL data for MOCO. |
There was a problem hiding this comment.
From this update, mysql images will not contain moco-init.
| @@ -0,0 +1,2 @@ | |||
| * | |||
| !workspace | |||
There was a problem hiding this comment.
This exclusion is not necessary.
There was a problem hiding this comment.
Thanks, deleted.
2c2a3e4
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #535
Push mysqldcontainer image to ghcr.io.
This PR only pushes the image.
The pushed image needs to be changed to be used by MOCO, but this will be done in another PR.