Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support k8s 1.30 and 1.31 #727

Merged
merged 14 commits into from
Sep 18, 2024
Merged

support k8s 1.30 and 1.31 #727

merged 14 commits into from
Sep 18, 2024

Conversation

YZ775
Copy link
Contributor

@YZ775 YZ775 commented Aug 13, 2024

No description provided.

@YZ775 YZ775 marked this pull request as draft August 13, 2024 09:02
@YZ775 YZ775 force-pushed the support-k8s-1.30 branch 3 times, most recently from 72fe9bf to a331901 Compare August 16, 2024 04:26
@YZ775 YZ775 mentioned this pull request Aug 19, 2024
Closed
4 tasks
@YZ775 YZ775 force-pushed the support-k8s-1.30 branch 3 times, most recently from 5aa4569 to 42d6033 Compare August 19, 2024 06:54
This was referenced Sep 5, 2024
Closed
Closed
@YZ775 YZ775 force-pushed the support-k8s-1.30 branch 2 times, most recently from 52f8e38 to b749124 Compare September 11, 2024 01:57
@YZ775 YZ775 marked this pull request as ready for review September 12, 2024 00:10
@YZ775 YZ775 changed the title support k8s 1.30 support k8s 1.30 and 1.31 Sep 12, 2024
chez-shanpu
chez-shanpu previously approved these changes Sep 13, 2024
View reviewed changes
Copy link

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@chez-shanpu chez-shanpu self-requested a review September 13, 2024 01:03
chez-shanpu
chez-shanpu previously approved these changes Sep 13, 2024
View reviewed changes
Copy link

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ymmt2005
ymmt2005 reviewed Sep 13, 2024
View reviewed changes
.github/workflows/ci-e2e.yaml Outdated
@@ -20,12 +20,12 @@ jobs:
name: Integration tests with MySQL
strategy:
matrix:
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.0"]
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.0", "8.4.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't our policy support only the latest LTS release?
I mean, we do not need to keep 8.4.0 here.

Suggested change
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.0", "8.4.2"]
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.2"]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also write 8.0.39

ymmt2005
ymmt2005 reviewed Sep 13, 2024
View reviewed changes
.github/workflows/ci-e2e.yaml Outdated
if: steps.changed-files.outputs.any_changed == 'true'

e2e-mysql:
name: Supported MySQL versions End-to-End Tests
strategy:
matrix:
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.0"]
k8s-version: ["1.29.4"]
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.0", "8.4.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

ymmt2005
ymmt2005 reviewed Sep 13, 2024
View reviewed changes
DEVELOP.md Outdated
@@ -84,23 +84,23 @@ MySQL versions appear twice:
name: Integration tests with MySQL
strategy:
matrix:
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.0"]
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.0", "8.4.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

ymmt2005
ymmt2005 reviewed Sep 13, 2024
View reviewed changes
DEVELOP.md Outdated
...
# Matrix tests for different MySQL versions on the latest supported Kubernetes version.
e2e-mysql:
name: Supported MySQL versions End-to-End Tests
strategy:
matrix:
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.0"]
k8s-version: ["1.29.4"]
mysql-version: ["8.0.28", "8.0.36", "8.0.37", "8.4.0", "8.4.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

ymmt2005
ymmt2005 reviewed Sep 13, 2024
View reviewed changes
README.md Outdated
@@ -26,8 +26,8 @@ Blog article: [Introducing MOCO, a modern MySQL operator on Kubernetes](https://

## Supported software

- MySQL: 8.0.28, 8.0.36, 8.0.37, 8.4.0
- Kubernetes: 1.27, 1.28, 1.29
- MySQL: 8.0.28, 8.0.36, 8.0.37, 8.4.0, 8.4.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- MySQL: 8.0.28, 8.0.36, 8.0.37, 8.4.0, 8.4.2
- MySQL: 8.0.28, 8.0.36, 8.0.37, 8.4.2

chez-shanpu
chez-shanpu previously approved these changes Sep 17, 2024
View reviewed changes
Copy link

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ymmt2005
ymmt2005 previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YZ775 YZ775 dismissed stale reviews from ymmt2005 and chez-shanpu via 1f2cc5f September 17, 2024 08:50
@chez-shanpu chez-shanpu self-requested a review September 17, 2024 09:22
shunki-fujita
shunki-fujita previously approved these changes Sep 17, 2024
View reviewed changes
@YZ775
Copy link
Contributor Author

YZ775 commented Sep 18, 2024

There are no changes that will cause StatafulSet to restart since latest release. So I reverted update of moco-agent.

chez-shanpu
chez-shanpu approved these changes Sep 18, 2024
View reviewed changes
Copy link

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YZ775 YZ775 merged commit 742ccbc into main Sep 18, 2024
23 checks passed
@YZ775 YZ775 deleted the support-k8s-1.30 branch September 18, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chez-shanpu chez-shanpu chez-shanpu approved these changes

@ymmt2005 ymmt2005 ymmt2005 left review comments

@shunki-fujita shunki-fujita shunki-fujita left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YZ775 @ymmt2005 @chez-shanpu @shunki-fujita