Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: Adding new NextEventRaw method #1

Open
wants to merge 1 commit into
base: release/7.8.x
Choose a base branch
from

Conversation

gaelL
Copy link
Member

@gaelL gaelL commented Oct 6, 2022

This methode allow go-concourse users to get raw sse.Event from the eventstream.

This offer an handy way to fully get an event (payload and event_id), Instead of a decoded atc.Event.

This function also provide a workaround for concourse#8585

Changes proposed by this PR

closes #

  • done
  • todo

Notes to reviewer

Release Note

@gaelL
Copy link
Member Author

gaelL commented Oct 6, 2022

This PR is here as doc reference of our actual change applied to Concourse.
This branch is used into our product as replacement of concourse/go-concourse.
We could rebase this branch in case of Concourse upgrade

@gaelL gaelL force-pushed the gl_issue_8585 branch 2 times, most recently from a48b03d to 6125009 Compare October 7, 2022 11:21
This methode allow go-concourse users to get raw sse.Event from the
eventstream.

This offer an handy way to fully get an event (payload and event_id), Instead of
a decoded atc.Event.

This function also provide a workaround for concourse#8585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant