Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support updating template store #607

Merged
merged 8 commits into from
Oct 13, 2024

Conversation

Abiji-2020
Copy link
Contributor

@Abiji-2020 Abiji-2020 commented Oct 4, 2024

closes #600

📑 Description

  • Created a subcommand template for the command `update
  • The template command takes the flags --path=<path> --version=<version> --icon=<icon> --repo = <repo> and accepts the command if any of them is present. Else give error

✅ Checks

  • I have tested my code (provide screenshots or screen recordings of a working solution)
  • I have performed a self-review of my code

ℹ Additional context

Before using the command :
image

Command:
image

After using the command:
image

…d updates the template store

Signed-off-by: Abinand P <[email protected]>
@Abiji-2020 Abiji-2020 requested a review from a team as a code owner October 4, 2024 12:34
@Abiji-2020
Copy link
Contributor Author

@quest-bot loot #600

Copy link

quest-bot bot commented Oct 4, 2024

Quest PR submitted! image Quest PR submitted!

@Abiji-2020, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 4, 2024
@Abiji-2020
Copy link
Contributor Author

@petar-cvit reviews on the PR?

cyctl/internal/update/template_store.go Outdated Show resolved Hide resolved
cyctl/internal/update/template_store.go Outdated Show resolved Hide resolved
cyctl/internal/update/template_store.go Outdated Show resolved Hide resolved
cyctl/internal/update/template_store.go Outdated Show resolved Hide resolved
cyctl/internal/update/template_store.go Outdated Show resolved Hide resolved
@Abiji-2020
Copy link
Contributor Author

@petar-cvit I have updated all the fields from the suggestion and In case we need to modify the log add a comment on it, It will be resolved 🧡.

cyctl/internal/update/template_store.go Outdated Show resolved Hide resolved
cyctl/internal/update/template_store.go Outdated Show resolved Hide resolved
@Abiji-2020
Copy link
Contributor Author

@petar-cvit the requested Changes are updated sir

Short: "updates template values; takes template name as argument and updates values provided by flags",
Long: "updates template values; takes template name as argument with flags --path=<path> --repo=<repo> --version=<version> --icon=<icon> ",
Example: updateTemplateStoreExample,
Args: cobra.ExactArgs(1),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add alias here:

Aliases: []string{"templates"},

#607 (comment)

@Abiji-2020
Copy link
Contributor Author

@petar-cvit updated the alias in the cobra command

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abiji-2020 🧡

@petar-cvit petar-cvit merged commit 4dacc0c into cyclops-ui:main Oct 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support updating template stores using cyctl
2 participants