feat(cyclops-ui): Dropdown menu to accept other then just enum fields #620
Conversation
|
hey @petar-cvit can you please review this pr in your free time? |
|
@quest-bot loot #50 |
There was a problem hiding this comment.
Hey @s-vamshi, I’m having trouble running this code. It seems that mode: ”tags" sends the values as arrays, which breaks on the backend. I would much rather prefer a dropdown that sends a single value instead of an array of one value.
Check an example of Select with a Custom dropdown from AntDesign to get an idea of how you could implement this.
If it makes sense, you can extract it into a separate component (something like SuggestInput.tsx perhaps).
Let me know if you can make it work and if you encounter issues with this approach!
|
Hey @KaradzaJuraj, thanks for the suggestions, I will use custom drop-down in a new component instead of making changes to SelectInput component! |
…r-then-just-enum-fields
|
Hey @KaradzaJuraj @petar-cvit added a new suggestionInput field using custom dropdown screen-capture.webm |
There was a problem hiding this comment.
Looks great @s-vamshi! Just one more change and we can add this to the codebase 🚀
| value={newOption} | ||
| onChange={(event) => setNewOption(event.target.value)} | ||
| onKeyDown={(e) => e.stopPropagation()} | ||
| onKeyPress={(e) => e.key === "Enter" && addOptionOnEnter()} |
There was a problem hiding this comment.
OnKeyPress is deprecated; can you move the functionality to onKeyDown?
There was a problem hiding this comment.
hey @KaradzaJuraj, moved the logic to onkeydown!
|
hey @KaradzaJuraj done with the changes! |
closes #50
📑 Description
Dropdown menu to accept other then just enum fields when json key has x-suggestions
✅ Checks
ℹ Additional context
screen-capture.15.webm