-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cylc remove
flow-aware and extend to historical tasks
#6370
Draft
MetRonnie
wants to merge
18
commits into
cylc:master
Choose a base branch
from
MetRonnie:cylc-remove
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,707
−624
Commits on Oct 30, 2024
-
`json.dumps()`/`json.loads()` are relatively slow (~1us). But these functions are likely to be called many times with `flow={1}`.
Configuration menu - View commit details
-
Copy full SHA for cfedb43 - Browse repository at this point
Copy the full SHA cfedb43View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf86418 - Browse repository at this point
Copy the full SHA bf86418View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07b9600 - Browse repository at this point
Copy the full SHA 07b9600View commit details -
Configuration menu - View commit details
-
Copy full SHA for 691bd4a - Browse repository at this point
Copy the full SHA 691bd4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d37215e - Browse repository at this point
Copy the full SHA d37215eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a25bb63 - Browse repository at this point
Copy the full SHA a25bb63View commit details
Commits on Nov 1, 2024
-
cylc remove
unsets any prereq satisfaction provided by the removed ……tasks in the given flow(s)
Configuration menu - View commit details
-
Copy full SHA for 312bfe4 - Browse repository at this point
Copy the full SHA 312bfe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbcc27e - Browse repository at this point
Copy the full SHA fbcc27eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9c107d - Browse repository at this point
Copy the full SHA a9c107dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78da333 - Browse repository at this point
Copy the full SHA 78da333View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69e4254 - Browse repository at this point
Copy the full SHA 69e4254View commit details -
Configuration menu - View commit details
-
Copy full SHA for 572af1f - Browse repository at this point
Copy the full SHA 572af1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3afe077 - Browse repository at this point
Copy the full SHA 3afe077View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8461e71 - Browse repository at this point
Copy the full SHA 8461e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 841321e - Browse repository at this point
Copy the full SHA 841321eView commit details -
cylc remove
: handle downstream tasks correctly- Update data store with changed prereqs - Don't un-queue downstream task if: - the task is already preparing - the task exists in flows other than that being removed - the task's prereqs are still satisfied overall - Remove the downstream task from the pool if it no longer has any satisfied prerequisite tasks
Configuration menu - View commit details
-
Copy full SHA for 85072c4 - Browse repository at this point
Copy the full SHA 85072c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f541091 - Browse repository at this point
Copy the full SHA f541091View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39be53f - Browse repository at this point
Copy the full SHA 39be53fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.