Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcast: fix dictionary changed size during iteration error #6397

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Oct 8, 2024

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
Copy link
Member Author

)Replicating the conditions that trigger this is rather problematic, hence the lack of a test)

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@hjoliver
Copy link
Member

(I don't think this needs multiple reviewers, but since you've deliberately assigned several I'll leave it unmerged for now).

@oliver-sanders oliver-sanders removed the request for review from markgrahamdawson October 11, 2024 08:40
@wxtim wxtim merged commit 8f27ae8 into cylc:8.3.x Oct 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants