Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't demote job failed messages to debug. #6401

Closed
wants to merge 2 commits into from

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Oct 11, 2024

Currently, we demote task messages to DEBUG level if they are more or less redundant with logged state changes.

However, this isn't ideal for job failure messages because,

  • if there are any retries lined up, the state change straight to waiting, with no indication of failure, looks wrong
  • job failures should really always be logged as critical (even if the graph is designed to handle it)

Example:

[scheduling]
    [[graph]]
        R1 = "a"
[runtime]
    [[a]]
        script = false
        execution retry delays = PT5S

Current:

Screenshot (12)

This branch:

Screenshot (11)

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver added small could be better Not exactly a bug, but not ideal. labels Oct 11, 2024
@hjoliver hjoliver added this to the 8.3.5 milestone Oct 11, 2024
@hjoliver hjoliver self-assigned this Oct 11, 2024
@hjoliver
Copy link
Member Author

I don't think this warrants a change log entry or tests.

@oliver-sanders
Copy link
Member

Please see #6169

@oliver-sanders oliver-sanders added the duplicate This is a duplicate of something else label Oct 11, 2024
@oliver-sanders oliver-sanders modified the milestones: 8.3.5, 8.3.6 Oct 14, 2024
@hjoliver
Copy link
Member Author

Closing as a duplicate of #6169 in light of discussion to change the log level of both submission and execution failures (with retries) in the same PR.

@hjoliver hjoliver closed this Oct 24, 2024
@hjoliver hjoliver deleted the tweak-log-msg-demotion branch November 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal. duplicate This is a duplicate of something else small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants