-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unicode character in cylc show
output
#6432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly an improvement anyway, in terms of how it looks.
cylc show
output
I don't have this issue in the same RHEL 9 environment? [edit] Neither does Ronnie now, probably fixed by a system update. Happy to change, but would like to get a handle on what chars are likely to be better supported before fixing one environment and breaking another. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked it up.
The previous icon was Unicode v3 (added in the 2000s), this PR changes it to an icon in Unicode v1 (added in the 90s).
So, I guess, try to keep to older Unicode icons (have just checked the Tui icons, they are all v1).
@MetRonnie, to fix the test failure:
|
(Unrelated flaky macos test fail) |
For some reason, the
U+2999
"Dotted Fence" character is not displaying on my RHEL9 terminal despite working before in RHEL7.My font is JetBrains Mono, but changing back to the default font doesn't help.
Replaced with
U+2506
"Box Drawings Light Triple Dash Vertical" as it seems to be more widespread.Check List
CONTRIBUTING.md
and added my name as a Code Contributor.?.?.x
branch.