Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore requests to trigger or set active tasks with flow=none #6433

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

hjoliver
Copy link
Member

Close #5635

What: see title

Why: triggering (or setting) with --flow=none should by definition have no impact on current or future flows.

(Tasks in n=0 have flows assigned already, and only cylc remove can undo that).

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver added the bug Something is wrong :( label Oct 21, 2024
@hjoliver hjoliver added this to the 8.3.6 milestone Oct 21, 2024
@hjoliver hjoliver self-assigned this Oct 21, 2024
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, we can't get the command to fail validation (would requires memory access from the server thread, nasty), so I think this is the best handling of the situation we are going to be able to come up with.

Given that we're ignoring the trigger completely, ERROR might make more sense than WARNING.

@hjoliver
Copy link
Member Author

Agreed, I've upgraded the warnings to errors.

Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I've upgraded the warnings to errors.

Just need to upgrade the test from warning to error it seems.

LGTM otherwise 👍

@dwsutherland dwsutherland merged commit df89a77 into cylc:8.3.x Oct 21, 2024
27 checks passed
@hjoliver hjoliver deleted the active-flow-none branch October 23, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants