Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejig #265

Merged
merged 12 commits into from
Nov 8, 2023
Merged

Rejig #265

merged 12 commits into from
Nov 8, 2023

Commits on Nov 1, 2023

  1. refactor: move utilities out of the entry_points module

    * Move utils out of the entry points module and move the rose-stem entry
      point in.
    * Move fileinstall into its own module.
    * Sort imports.
    oliver-sanders committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3d3e3f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4f1cbb View commit details
    Browse the repository at this point in the history
  3. tests: fix accidentally skipped tests

    * `['a'].sort()` returns `None` not `['a']`
    * So `assert a.sort() == b.sort()` will always be `True`.
    oliver-sanders committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9bd5143 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f33ba1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1ee6462 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ba07063 View commit details
    Browse the repository at this point in the history
  7. entry_points: catch None values earlier

    * Avoid having to handle None values for srcdir/rundir throughout
      the codebase by catching them earlier.
    oliver-sanders committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    aa79c43 View commit details
    Browse the repository at this point in the history
  8. utils: split the loading and processing of the config

    * A future rose stem interface will need to inject itself
      between config loading and processing.
    * So colocate the plugin processing logic into one function.
    oliver-sanders committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d1ff77d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0f376d1 View commit details
    Browse the repository at this point in the history
  10. entry_points: remove type uncertainty

    * Entry points accept missing or None values for arguments, however,
      this can never happen in practice.
    * Set the appropriate type hints and remove code paths which could not
      get executed.
    oliver-sanders committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9bef3c8 View commit details
    Browse the repository at this point in the history
  11. tests: amend docstrings

    * Amend false docstrings.
    * Rename a couple of modules.
    oliver-sanders committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b993900 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. feedback

    oliver-sanders committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8169941 View commit details
    Browse the repository at this point in the history