-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump version #323
Closed
Closed
bump version #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.8.8 to 1.8.10. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.8.8...v1.8.10) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
actions: test up to python 3.11
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ns/checkout-4 Bump actions/checkout from 3 to 4
…gh-action-pypi-publish-1.8.10 Bump pypa/gh-action-pypi-publish from 1.8.8 to 1.8.10
…lc#255) * Suggested change to warning text when integers with leading zeros are found in the cylc workflow definition. * Apply suggestions from code review Co-authored-by: Tim Pillinger <[email protected]> --------- Co-authored-by: Oliver Sanders <[email protected]> Co-authored-by: Tim Pillinger <[email protected]>
Improve test coverage Co-authored-by: Oliver Sanders <[email protected]>
* upstream/1.3.x: Bump dev version Prepare release 1.3.1 added flake8-type-checking (cylc#257) remove back compatibility check Raise error if = not in define Ensure that a `:suite.rc` is added to the template language when creating defines.
GH Actions: use branch sync workflow
* Move utils out of the entry points module and move the rose-stem entry point in. * Move fileinstall into its own module. * Sort imports.
* `['a'].sort()` returns `None` not `['a']` * So `assert a.sort() == b.sort()` will always be `True`.
* Avoid having to handle None values for srcdir/rundir throughout the codebase by catching them earlier.
* A future rose stem interface will need to inject itself between config loading and processing. * So colocate the plugin processing logic into one function.
* Entry points accept missing or None values for arguments, however, this can never happen in practice. * Set the appropriate type hints and remove code paths which could not get executed.
* Amend false docstrings. * Rename a couple of modules.
have a rose-suite.conf
…ort_CYLC_SYMLINKS Repopulate cached GlobalConfig object if CYLC_SYMLINKS exported to env.
* Rose will now take over the role of managing its event loop. * Addresses cylc#274
* Jinja2 patching wasn't reverted in the event of error. * This isn't an issue for cylc/cylc-rose usage (as we exit on error). * But in the tests, we may continue on error so need to ensure this cleanup logic gets called.
* The Cylc install and reinstall interfaces are now async. * This adapts rose-stem to handle the change and adjusts the tests.
fileinstall: remove asyncio logic
tests: fix flaky text
* The install/reinstall commands used to be called via the CLI. * They were converted to run via the Python API, but some of the CLI wrapper legacy remained. * This strips away the CLI wrapper to make native Python testing easier.
🤖 Merge 1.3.x-sync into master
🤖 Merge 1.3.x-sync into master
🤖 Merge 1.3.x-sync into master
Co-authored-by: Ronnie Dutta <[email protected]>
add developer docs
* stem tests: move monkeymodule the top level conftest * stem tests: remove intermediate fixtures * Remove fixtures specific to individual tests. * Move parametrization into tests where possible. * stem tests: remove outdated docs and unused code * stem tests: remove subprocess styled wrapper for rose stem execution * We used to use subprocess to run the tests. * This was removed but the logic for returncodes etc was kept. * stem tests: add descriptions to rose-stem tests. * Link each test back to the original source (metomi/rose). * Try to determine the purpose of each test and hint it in comments. * stem tests: use the rose config to check template vars * Rather than testing the config file line by line, read the config in and test the variables exist in the section we expect them to be in. * Add installed template vars into the rose stem fixture's return result. * stem tests: remove workflow name parameter * Don't explicitly speciy the workflow name, `cylc install` sets this to the basename of the source dir automatically. * stem tests: always use fixture to run rose_stem * Some tests were using `rose_stem_runner`, other's weren't and were replicating its logic locally. * stem tests: sort out fixture scopes * Convert the Rose Stem project fixture to module scope to avoid re-creating it for every test. * Moved the cleanup logic out of the Rose Stem project fixture into to fixture that runs `rose stem` itself. * Niceified the fixture interfaces. * Converted the function-scoped fixtures to request only function-scoped fixtures themselves. * stem tests: unify rose_stem teardown logic * Move `rose_stem` test fixture into the conftest.py with the others * Unify with the `test_dir` fixture (for provisioning the Cylc run dir) that all the other fixtures use. * Remove the resource teardown logic from the `rose_stem` fixture, fixing a bug where the source directories from successful tests could be left behind. * review feedback
* upstream/master: (47 commits) simplify rose stem tests (cylc#314) Apply suggestions from code review add developer docs build(deps): bump pypa/gh-action-pypi-publish from 1.8.11 to 1.8.14 (cylc#301) [skip ci] tests: remove defunct cli wrappers (cylc#297) tests/functional: fix scoping issues setup: add missing pytest-asyncio test dependency install/reinstall: adapt to new async interfaces tests: fix flaky text fileinstall: remove asyncio logic Bump codecov/codecov-action from 3 to 4 (cylc#295) use fqdn in rose-stem tests (cylc#294) Update setup.cfg setup: bump rose version fix merge mistake fix flake8 fixed a test Apply suggestions from code review Bump actions/setup-python from 4 to 5 (cylc#280) Update tests/functional/test_utils.py ...
🤖 Merge 1.3.x-sync into master
oliver-sanders
force-pushed
the
1.3.x-sync
branch
from
May 13, 2024 09:58
6f5afd3
to
eb7fcff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync PR