Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minicylc: fix animations #71

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

oliver-sanders
Copy link
Member

  • Animations had been broken by a change in graphviz output (there are now newlines before and after the node content).

* Animations had been broken by a change in graphviz output (there are
  now newlines before and after the node content).
@oliver-sanders oliver-sanders added the bug Something isn't working label Jul 26, 2022
@oliver-sanders oliver-sanders added this to the 1.4.1 milestone Jul 26, 2022
@oliver-sanders oliver-sanders self-assigned this Jul 26, 2022
@oliver-sanders oliver-sanders mentioned this pull request Jul 26, 2022
26 tasks
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but only working on Firefox (...with a fair bit of encouragement needed first...)

@oliver-sanders
Copy link
Member Author

I don't think we're going to be able to get this one fixed in time.

The animations were trying to play on Firefox before but in a broken way so would like to use this version to deploy the docs with.

Can redeploy when we find a fix for the others.

#72

@oliver-sanders oliver-sanders merged commit 98932fa into cylc:master Jul 27, 2022
@oliver-sanders oliver-sanders deleted the minicylc-fix branch July 27, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants