-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch user initials from UIServer #1505
Fetch user initials from UIServer #1505
Conversation
Is a changes.md entry required for this one? |
No need for a changelog entry for this ticket (no one is going to check the cylc-ui changelog in the first place to major things only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Note to reviewers, PAM doesn't return a helpful initials field, but other authenticators can.
Closes #1504
The userprofile endpoint has been extended in cylc/cylc-uiserver#510 so it now provides user initials.
If for whatever reason the initials field is empty the avatar will be a user symbol
And if the initials field is populated the avatar will look like one of the two
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.