Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch user initials from UIServer #1505

Merged

Conversation

markgrahamdawson
Copy link
Contributor

@markgrahamdawson markgrahamdawson commented Oct 5, 2023

Closes #1504

The userprofile endpoint has been extended in cylc/cylc-uiserver#510 so it now provides user initials.

If for whatever reason the initials field is empty the avatar will be a user symbol
image

And if the initials field is populated the avatar will look like one of the two
image
image

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@markgrahamdawson
Copy link
Contributor Author

Is a changes.md entry required for this one?

@markgrahamdawson markgrahamdawson marked this pull request as ready for review October 12, 2023 12:50
@oliver-sanders oliver-sanders added this to the 2.2.0 milestone Oct 16, 2023
@oliver-sanders
Copy link
Member

No need for a changelog entry for this ticket (no one is going to check the cylc-ui changelog in the first place to major things only)

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Note to reviewers, PAM doesn't return a helpful initials field, but other authenticators can.

src/components/cylc/workflow/Toolbar.vue Outdated Show resolved Hide resolved
src/components/cylc/workflow/Toolbar.vue Outdated Show resolved Hide resolved
src/components/cylc/workflow/Toolbar.vue Outdated Show resolved Hide resolved
@oliver-sanders oliver-sanders modified the milestones: 2.2.0, 2.3.0 Nov 2, 2023
@MetRonnie MetRonnie modified the milestones: 2.3.0, 2.2.0 Nov 2, 2023
@MetRonnie MetRonnie changed the title fetch userProfile data from Jupyter Server Fetch user initials from UIServer Nov 2, 2023
@MetRonnie MetRonnie merged commit c6c1610 into cylc:master Nov 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source user avatar initials from Jupyter Server
3 participants