toolbar: disable n-window selector if appropriate #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Closes cylc#1845 * Disable the n-window selector if the authenticated user does not have the required permissions to run the setGraphWindowExtent mutation.
MetRonnie
approved these changes
Nov 4, 2024
| @@ -108,6 +108,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| <v-select | |||
| v-model="nWindow" | |||
| :items="[0,1,2,3]" | |||
| :disabled="!user.permissions?.includes('setGraphWindowExtent')" | |||
There was a problem hiding this comment.
This could be on the v-chip rather than the v-select
cylc-ui/src/components/cylc/workspace/Toolbar.vue
Lines 87 to 89 in 15de3a0
There was a problem hiding this comment.
The reason I didn't do this is so that users can still access the help text explaining what the control is for as "n=1" is not especially explanatory by itself.
hjoliver
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.