Update Vuetify from 2.2.6 to 2.3.9

[kinow]

These changes partially address #465

Updates to the latest version of Vuetify. Looked at each view of our app, with JupyterHub and five running. Everything looks OK.

Kudos to Vuetify developers. They kept backward compatibility as it's not a new major release, and deprecated the values changed, without breaking the user's code. Furthermore, they also added warning messages to each deprecated item, with instructions how to fix it 🙏

So after updating the version, I simply fixed as they suggested, and then no more warnings in the console.

Requirements check-list

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Does not need tests (why?).
• No change log entry required (why? e.g. invisible to users).
• No documentation update required.

[codecov-commenter]

Codecov Report

Merging #466 into master will increase coverage by 12.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #466       +/-   ##
===========================================
+ Coverage   57.07%   69.35%   +12.27%     
===========================================
  Files          53       57        +4     
  Lines        1046     1266      +220     
  Branches       75       79        +4     
===========================================
+ Hits          597      878      +281     
+ Misses        435      367       -68     
- Partials       14       21        +7     

Flag	Coverage Δ
#e2e	48.53% <ø> (+5.29%)	⬆️
#unittests	52.64% <ø> (+6.42%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/components/cylc/Drawer.vue	75.00% <ø> (ø)
src/components/cylc/graph/Graph.vue	24.52% <ø> (+24.52%)	⬆️
src/services/mock/workflow.service.mock.js	87.50% <0.00%> (-12.50%)	⬇️
src/services/gquery.js	77.41% <0.00%> (-6.46%)	⬇️
src/graphql/queries.js	100.00% <0.00%> (ø)
src/store/workflows.module.js	100.00% <0.00%> (ø)
src/services/workflow.service.js	0.00% <0.00%> (ø)
src/views/Tree.vue	66.66% <0.00%> (ø)
src/components/cylc/tree/deltas.js	100.00% <0.00%> (ø)
src/mixins/treeview.js	100.00% <0.00%> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4992128...7642c1d. Read the comment docs.

[kinow]

Really no idea how to fix the 2 tests failing. Managed to fix one, with a lot of changes to Vuex, which is not a good sign. Probably something in the new version that changed requires us to change something simple in the way we create the object for testing... hopefully.

[kinow]

Failing test should be fixed now. Lessons learned:

• We were using mapState directly in the component, which is fine, but means that writing a unit test for the component requires you to properly handle Vuex in the test too. Our store has many entries already, even though it's far from comparing to large applications. Which means it's harder to maintain tests and make sure everything works.
• By moving the mapState to the caller of the component, the unit tests gets much simpler. All you need to pass to the component is a prop. Testing components with props in Mocha+Chai is easy-peasy.
• I thought the connection-status component was also hidden, but turns out now the component is present, but the SnackBar component is hidden; I guess Vuetify has some reason for doing it that way
• Mocha API for parameterized tests is documented under their "Dynamically Generating Tests" docs section. Not as nice as in other test frameworks, but it works well.
• The output of failing tests is not really helpful if you have similar tests, meaning that you have to scroll up-down to find the line of the error, and it may still not match due to sourcemap... so you need to locate the function name. A helpful tip is to add a message to the last function in the assertion (e.g. expect(predicate).to.be(true, 'This is a helpful message').

[kinow]

Set to 0.2, but can be merged later and included in 0.3 too, no hurry on this one 👍

[hjoliver]

LGTM

[kinow]

Pushed to 0.3. Will rebase it later.

[kinow]

2.3.9 is out, but we can update that later. Should be much easier than upgrading 2.2 to 2.3.

[kinow]

No issues updating to 2.3.9, so pushed the changes to this PR in my last commit. Tested some views, and found nothing wrong with how components were displayed 👍 also no build errors.

[oliver-sanders]

Tested as working, all seems good.