Improve style of Lumino tab close button #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Nov 10, 2021
| .p-BoxPanel { | ||
| .lm-BoxPanel { |
There was a problem hiding this comment.
.p-* is deprecated apparently: jupyterlab/lumino#106
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 86 86
Lines 1701 1701
Branches 109 109
=======================================
Hits 1556 1556
Misses 119 119
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
MetRonnie
commented
Nov 10, 2021
| .p-TabBar-tabCloseIcon:before { | ||
| content: 'X'; | ||
| .lm-TabBar-tabCloseIcon:before { | ||
| content: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' style='width:24px;height:24px' viewBox='0 0 24 24'%3E%3Cpath fill='currentColor' d='M19,6.41L17.59,5L12,10.59L6.41,5L5,6.41L10.59,12L5,17.59L6.41,19L12,13.41L17.59,19L19,17.59L13.41,12L19,6.41Z' /%3E%3C/svg%3E"); |
There was a problem hiding this comment.
SVG taken from material design close icon
hjoliver
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change with no associated Issue.
Before:
After:
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.