Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-store: log workflow events to info level #348

Merged
merged 1 commit into from
May 20, 2022
Merged

data-store: log workflow events to info level #348

merged 1 commit into from
May 20, 2022

Conversation

oliver-sanders
Copy link
Member

  • To assist with debugging the UIS under normal operation bump the logging of workflow events (registered, connected, disconnected, etc events) from debug to info levels.
  • Centralised workflow event logging, included more argument info & gave all events a prefix to help us to grep them out when needed.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.
  • No dependency changes.

@oliver-sanders oliver-sanders added this to the 1.1.0 milestone May 16, 2022
@oliver-sanders oliver-sanders self-assigned this May 16, 2022
@oliver-sanders oliver-sanders mentioned this pull request May 17, 2022
Merged
7 tasks
hjoliver
hjoliver approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs some tweaking for type-checking. (fixed by #350?)

@oliver-sanders
Copy link
Member Author

(rebased)

@oliver-sanders
Copy link
Member Author

Could potentially bump this to the 1.0.2 milestone (only adds logging) but no pressure from our side (happy to use dev builds for the moment).

@oliver-sanders
data-store: log workflow events to info level
03a38db 
* To assist with debugging the UIS under normal operation bump the
  logging of workflow events (registered, connected, disconnected, etc events)
  from debug to info levels.
* Centralised workflow event logging, included more argument info & gave
  all events a prefix to help us to `grep` them out when needed.
@hjoliver hjoliver modified the milestones: 1.1.0, 1.0.2 May 20, 2022
@hjoliver
Copy link
Member

Banging this one foward for rc3.

@hjoliver hjoliver merged commit d808078 into cylc:master May 20, 2022
@oliver-sanders oliver-sanders deleted the workflow-event-logging branch June 6, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
small
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @hjoliver @wxtim