Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: 1.0.2 #351

Merged
merged 2 commits into from
May 20, 2022
Merged

Prepare release: 1.0.2 #351

merged 2 commits into from
May 20, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 19, 2022

⚡ Merging this PR will automatically create a GitHub Release & publish the package ⚡

This PR was created by the Release stage 1 - create release PR workflow, triggered by @hjoliver

Tests:

  • Tests last run on master: test.yml
  • ✔️ Build check passed - see the workflow run (number 11) for more info

Checklist:

  • Milestone complete?
    ⚠️ Couldn't find milestone matching 1.0.2
  • Changelog up-to-date?
    • Examine pull requests made since the last release
    • "Released on" date updated? ✔️ 2022-05-19

Next steps:

  • @hjoliver should request 1 or 2 reviews
  • If any further changes are needed, push to this PR branch
  • After merging, the bot will comment below with a link to the release (if not, look at the PR checks tab)

@github-actions github-actions bot added the release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish. label May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #351 (820845f) into master (d808078) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   78.68%   78.68%           
=======================================
  Files          11       11           
  Lines        1065     1065           
  Branches      206      206           
=======================================
  Hits          838      838           
  Misses        191      191           
  Partials       36       36           
Impacted Files Coverage Δ
cylc/uiserver/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d808078...820845f. Read the comment docs.

@hjoliver
Copy link
Member

Note I updated the UI on this PR branch (By copying the contents of cylc-ui/dist from a local build).

@hjoliver
Copy link
Member

In setup.cfg:

   cylc-flow==8.0rc3.*  # the .* permits dev versions 

I presume that's OK for the release.

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note I updated the UI on this PR branch (By copying the contents of cylc-ui/dist from a local build).

Sorry, my bad, the release instructions weren't too clear on this. The plan is:

  1. Release the UI.
  2. Use the GH action to bump the UI version (uses the official release build)
  3. Kick off the release process

cylc/cylc-admin#153 (comment)

No problem, no need to close this PR, suggest:

  1. Revert the UI update commit.
  2. Release the UI.
  3. Update the UIS UI version (on master).
  4. Rebase this PR.

@oliver-sanders
Copy link
Member

I presume that's OK for the release.

Yep, this permits maintenance releases whilst keeping the Cylc system components tightly coupled.

@hjoliver
Copy link
Member

A-ha, makes sense! (how the UI is updated).

I've removed that commit on this branch.

@MetRonnie
Copy link
Member

I have run the GH workflow to update the bundled UI : #354

@hjoliver All that's left is to rebase this branch onto master (and possibly update the changelog date seeing as this will probably go on into tomorrow UTC)

Workflow: Release stage 1 - create release PR, run: 11
@hjoliver
Copy link
Member

Hmm, we didn't have a pending-release heading in the change log prior to this, so the action changed the 1.0.1 heading. Doing a little manual surgery...

@hjoliver
Copy link
Member

@MetRonnie - this should be good to go now (rebased, change log tweaked).

@MetRonnie MetRonnie added this to the 1.0.2 milestone May 20, 2022
@MetRonnie MetRonnie requested a review from wxtim May 20, 2022 09:11
@wxtim wxtim merged commit c324fe8 into master May 20, 2022
@github-actions
Copy link
Contributor Author

✔️ success

Next steps for @hjoliver:


Comment created by workflow: Release stage 2 - auto publish, run: 16

@github-actions github-actions bot deleted the prepare-1.0.2 branch May 20, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants