-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release: 1.0.2 #351
Conversation
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 78.68% 78.68%
=======================================
Files 11 11
Lines 1065 1065
Branches 206 206
=======================================
Hits 838 838
Misses 191 191
Partials 36 36
Continue to review full report at Codecov.
|
Note I updated the UI on this PR branch (By copying the contents of cylc-ui/dist from a local build). |
In
I presume that's OK for the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note I updated the UI on this PR branch (By copying the contents of cylc-ui/dist from a local build).
Sorry, my bad, the release instructions weren't too clear on this. The plan is:
- Release the UI.
- Use the GH action to bump the UI version (uses the official release build)
- Kick off the release process
No problem, no need to close this PR, suggest:
- Revert the UI update commit.
- Release the UI.
- Update the UIS UI version (on master).
- Rebase this PR.
Yep, this permits maintenance releases whilst keeping the Cylc system components tightly coupled. |
A-ha, makes sense! (how the UI is updated). I've removed that commit on this branch. |
Workflow: Release stage 1 - create release PR, run: 11
Hmm, we didn't have a pending-release heading in the change log prior to this, so the action changed the 1.0.1 heading. Doing a little manual surgery... |
@MetRonnie - this should be good to go now (rebased, change log tweaked). |
✔️
|
⚡ Merging this PR will automatically create a GitHub Release & publish the package ⚡
This PR was created by the
Release stage 1 - create release PR
workflow, triggered by @hjoliverTests:
master
:Checklist:
1.0.2
2022-05-19
Next steps: