Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cylc-flow version #380

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Bump cylc-flow version #380

merged 1 commit into from
Aug 18, 2022

Conversation

MetRonnie
Copy link
Member

If the next uiserver release is a minor rather than maintenance one, then doesn't it need to have a dependency on the next cylc-flow minor release?

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Any dependency changes applied to setup.cfg.
  • Does not need tests
  • No change log entry required
  • No documentation update required.

@MetRonnie MetRonnie added question Flag this as a question for the next Cylc project meeting. small labels Aug 17, 2022
@MetRonnie MetRonnie added this to the 1.2.0 milestone Aug 17, 2022
@MetRonnie MetRonnie self-assigned this Aug 17, 2022
@hjoliver
Copy link
Member

If the next uiserver release is a minor rather than maintenance one, then doesn't it need to have a dependency on the next cylc-flow minor release?

But I suppose we can't be sure yet that the next UIS release will not be a maintenance release (we might find a bug requiring a quick fix...).

@MetRonnie
Copy link
Member Author

I say we branch off the 1.1.0 tag in that case

@oliver-sanders
Copy link
Member

If the next uiserver release is a minor rather than maintenance one, then doesn't it need to have a dependency on the next cylc-flow minor release?

Yes, this is on the cylc-admin issue template (metadata section) but got missed this time around. The same also applies to cylc-rose.

cylc/cylc-admin#157

@oliver-sanders
Copy link
Member

oliver-sanders commented Aug 18, 2022

Note that the tests are run against the cylc-flow master branch. For maintenance releases we would need to modify the test workflow to either install from a selected branch. Installing the released version is probably preferable.

@MetRonnie
Copy link
Member Author

Actually as there's currently the dependency on cylc-flow==8.0.*, it's currently installing cylc-flow master, then uninstalling and replacing with 8.0.1

- name: Install cylc-uiserver & dependencies
run: |
pip install git+https://github.com/cylc/cylc-flow@master
pip install -e .[all]

@hjoliver hjoliver merged commit 4d14920 into cylc:master Aug 18, 2022
@MetRonnie MetRonnie deleted the dev branch August 18, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Flag this as a question for the next Cylc project meeting. small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants