-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle trying to play workflows which require upgrade #455
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 1.3.x #455 +/- ##
==========================================
- Coverage 77.24% 76.77% -0.47%
==========================================
Files 12 12
Lines 1415 1408 -7
Branches 239 233 -6
==========================================
- Hits 1093 1081 -12
- Misses 276 279 +3
- Partials 46 48 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out by artificially changing the cylc_version
value to 8.0.3 in workflow_params
table, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebasing onto master
* Intercept error message about versions and upgrading and post it to a more helpful error message than stardard "This Cylc Play command failed" * Add a toggle for the --upgrade option of Cylc Play
Co-authored-by: Ronnie Dutta <[email protected]>
Co-authored-by: Ronnie Dutta <[email protected]>
Co-authored-by: Ronnie Dutta <[email protected]>
Any reason this can't go on 1.3.x? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dammit, I had a pending review, sorry.
Any reason this can't go on 1.3.x?
Yeah, this could go in 1.3.x, note 1.4.0 will hopefully be released shortly.
Co-authored-by: Oliver Sanders <[email protected]>
@oliver-sanders / @MetRonnie Want to hit the merge button? We don't have separate master/1.4.x branches, so I suppose that we haven't got any major changes? |
Co-authored-by: Ronnie Dutta <[email protected]>
Sibling: cylc/cylc-flow#5535
Closes #429
it to a more helpful error message than stardard "This Cylc Play command failed"
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect usersCylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.N/A?.?.x
branch.Manual Testing