Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin to next dev release #479

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jul 25, 2023

@wxtim wxtim requested a review from MetRonnie July 25, 2023 13:51
@wxtim wxtim self-assigned this Jul 25, 2023
@MetRonnie
Copy link
Member

Needs cylc/cylc-flow#5647

Also while you're here I spotted a deprecation warning in the pip install output, can you add

diff --git a/setup.cfg b/setup.cfg
index 6b3315b..713810b 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -21,7 +21,7 @@ description = Cylc UI Server
 long_description_content_type=text/markdown
 long_description = file: README.md
 license = GPL
-license_file = COPYING
+license_files = COPYING
 platforms = any
 classifiers =
     Environment :: Console

@MetRonnie MetRonnie added this to the 1.4.0 milestone Jul 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2b866af) 77.24% compared to head (aa20954) 77.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   77.24%   77.24%           
=======================================
  Files          12       12           
  Lines        1415     1415           
  Branches      239      239           
=======================================
  Hits         1093     1093           
  Misses        276      276           
  Partials       46       46           
Files Changed Coverage Δ
cylc/uiserver/__init__.py 87.50% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MetRonnie
Copy link
Member

Kicking tests

@MetRonnie MetRonnie closed this Jul 26, 2023
@MetRonnie MetRonnie reopened this Jul 26, 2023
@wxtim wxtim closed this Jul 26, 2023
@wxtim wxtim reopened this Jul 26, 2023
@MetRonnie
Copy link
Member

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 146c774..81df9df 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -33,6 +33,8 @@ jobs:
 
       - name: Build
         uses: cylc/release-actions/build-python-package@v1
+        with:
+          check-dependencies: false
 
       - name: Inspect
         run: |

@wxtim
Copy link
Member Author

wxtim commented Jul 26, 2023

@MetRonnie Still not working?

@MetRonnie MetRonnie merged commit 7a6e1b9 into cylc:master Jul 26, 2023
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants