Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add scan mutation #493

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

markgrahamdawson
Copy link
Contributor

@markgrahamdawson markgrahamdawson commented Sep 5, 2023

Closes #377

This was going to bee added as a rest endpoint but after discussion with @oliver-sanders it was decided it would be better to add another mutation to uiserver

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present). - NA
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.- NA
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch. - NA

@MetRonnie MetRonnie added this to the 1.5.0 milestone Sep 7, 2023
@markgrahamdawson markgrahamdawson marked this pull request as ready for review September 8, 2023 10:41
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved
cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Patch coverage: 61.53% and project coverage change: -0.08% ⚠️

Comparison is base (0f3205a) 75.39% compared to head (25ba516) 75.31%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   75.39%   75.31%   -0.08%     
==========================================
  Files          12       12              
  Lines        1410     1422      +12     
  Branches      234      235       +1     
==========================================
+ Hits         1063     1071       +8     
- Misses        297      301       +4     
  Partials       50       50              
Files Changed Coverage Δ
cylc/uiserver/resolvers.py 54.77% <28.57%> (-0.55%) ⬇️
cylc/uiserver/schema.py 72.22% <100.00%> (+1.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES.md Outdated Show resolved Hide resolved
cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved
cylc/uiserver/resolvers.py Show resolved Hide resolved
cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved
added name to CONTRIBUTING.md
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MetRonnie
Copy link
Member

@oliver-sanders Is that an approval or are you still yet to test etc?

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👍

@hjoliver hjoliver merged commit b043bb9 into cylc:master Sep 13, 2023
4 checks passed
MetRonnie pushed a commit to MetRonnie/cylc-uiserver that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scan endpoint
5 participants