-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add scan mutation #493
Feature add scan mutation #493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
==========================================
- Coverage 75.39% 75.31% -0.08%
==========================================
Files 12 12
Lines 1410 1422 +12
Branches 234 235 +1
==========================================
+ Hits 1063 1071 +8
- Misses 297 301 +4
Partials 50 50
☔ View full report in Codecov by Sentry. |
added name to CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
25ba516
to
d222a4b
Compare
@oliver-sanders Is that an approval or are you still yet to test etc? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too 👍
…tation Feature add scan mutation
Closes #377
This was going to bee added as a rest endpoint but after discussion with @oliver-sanders it was decided it would be better to add another mutation to uiserver
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present). - NACHANGES.md
entry included if this is a change that can affect users?.?.x
branch. - NA